README.md

@@ -1,38 +1,29 @@
 # CheckMyIP - [myip.bsd.cafe](https://myip.bsd.cafe)
 
-A Telnet, SSH, DNS and Simple HTTP Based Public IP Address Lookup Service
+A Telnet, SSH and Simple HTTP Based Public IP Address Lookup Service
 
 
 -----------------------------------------
 
 ### USAGE
 
-#### DNS
+-   **TELNET**:
-- **DNS TXT Record**:
+    -   Default: `telnet myip.bsd.cafe`
-  - Retrieve your IP via a DNS TXT record: `dig +short myip.bsd.cafe TXT @myip.bsd.cafe`
+    -   IPv4: `telnet myip4.bsd.cafe`
-
+    -   IPv6: `telnet myip6.bsd.cafe`
-#### Telnet
+-   **SSH**:
-- **Default**: `telnet myip.bsd.cafe`
+    -   Default: `ssh myip.bsd.cafe`
-- **IPv4**: `telnet myip4.bsd.cafe`
+    -   IPv4: `ssh myip4.bsd.cafe`
-- **IPv6**: `telnet myip6.bsd.cafe`
+    -   IPv6: `ssh myip6.bsd.cafe`
-
+    -   Your SSH client may require you to enter a username. You can use anything you want (`ssh -l imrootbitch myip.bsd.cafe`)
-#### SSH
+-   **CURL**:
-- **Default**: `ssh myip.bsd.cafe`
+    -   Default: `curl -L myip.bsd.cafe`
-- **IPv4**: `ssh myip4.bsd.cafe`
+    -   IPv4: `curl -L myip4.bsd.cafe`
-- **IPv6**: `ssh myip6.bsd.cafe`
+    -   IPv6: `curl -L myip6.bsd.cafe`
-- Your SSH client may require you to enter a username. You can use anything you want (`ssh -l username myip.bsd.cafe`)
+-   **WGET**:
-
+    -   Default: `wget -qO- myip.bsd.cafe`
-#### CURL
+    -   IPv4: `wget -qO- myip4.bsd.cafe`
-- **Default**: `curl -L myip.bsd.cafe`
+    -   IPv6: `wget -qO- myip6.bsd.cafe`
-- **IPv4**: `curl -L myip4.bsd.cafe`
-- **IPv6**: `curl -L myip6.bsd.cafe`
-
-#### WGET
-- **Default**: `wget -qO- myip.bsd.cafe`
-- **IPv4**: `wget -qO- myip4.bsd.cafe`
-- **IPv6**: `wget -qO- myip6.bsd.cafe`
-
-For HTTP (CURL and WGET above), use `myip.bsd.cafe/raw` to get only the IP address. This also works for the HTTP IPv4 and IPv6 addresses.
 
 -----------------------------------------
 ###   VERSION   ###
@@ -83,7 +74,7 @@ If you would rather set up your own private instance of CheckMyIP, then you can
 Install Dependencies (for example, on a FreeBSD jail)
 
 ```
-pkg install python39 py39-gssapi py39-paramiko py39-dnspython
+pkg install python39 py39-gssapi py39-paramiko
 ```
 
 Clone Repo and install
@@ -115,7 +106,7 @@ load_rc_config $name
 
 pidfile="/var/run/${name}.pid"
 command="/usr/local/bin/checkmyip.py"
-command_interpreter="/usr/local/bin/python3.11"
+command_interpreter="/usr/local/bin/python3.9"
 command_args="&"
 start_precmd="checkmyip_precmd"
 
@@ -136,6 +127,22 @@ service checkmyip enable
 service checkmyip start
 ```
 
+
+-----------------------------------------
+###   UPDATES IN V1.0.0 --> V1.1.0   ###
+
+**NEW FEATURES:**
+- Was seeing issues where SSH would be very slow to exchange. Likely related to log file sizes, so I change the logging function to turnover to new logging files every day.
+
+
+-----------------------------------------
+###   UPDATES IN V1.1.0 --> V1.3.0   ###
+
+- README updated for install on Ubuntu instead of CentOS
+- Small tweaks to support Python3
+
+
+
 -----------------------------------------
 ###   CONTRIBUTING   ###
 If you would like to help out by contributing code or reporting issues, please do!

checkmyip.py

@@ -1,14 +1,18 @@
-#!/usr/local/bin/python3.11
+#!/usr/local/bin/python3.9
+
 
 ##### BSD Cafe CheckMyIP Server                #####
 ##### Originally written by John W Kerns       #####
+##### http://blog.packetsar.com                #####
 ##### Forked to BSD Cafe by Stefano Marinelli  #####	
 ##### https://brew.bsd.cafe/BSDCafe/checkmyip  #####
 
-##### Inform version here #####
-version = "v1.3.2"
 
-##### Import necessary modules #####
+##### Inform version here #####
+version = "v1.3.0"
+
+
+##### Import python2 native modules #####
 import os
 import sys
 import time
@@ -17,34 +21,19 @@ import json
 import jinja2
 import paramiko
 import threading
-from concurrent.futures import ThreadPoolExecutor
-from dnslib import DNSRecord, DNSHeader, RR, TXT, QTYPE
-import logging  # Use built-in logging module
 
-##### Configure Logging #####
-LOG_DIR = "/var/log/checkmyip/"
-os.makedirs(LOG_DIR, exist_ok=True)
-
-# General Logger
-logging.basicConfig(
-    level=logging.INFO,
-    format="%(asctime)s: %(message)s",
-    handlers=[
-        logging.FileHandler(os.path.join(LOG_DIR, f"{time.strftime('%Y-%m-%d')}_checkmyip.log")),
-        logging.StreamHandler(sys.stdout)
-    ]
-)
-
-# Paramiko Logger
-paramiko_log = os.path.join(LOG_DIR, f"{time.strftime('%Y-%m-%d')}_ssh.log")
-paramiko.util.log_to_file(paramiko_log)
 
 ##### Jinja formatting for logging queries #####
 j2log = "Connection from: {{ ip }} ({{ port }}) ({{ proto }})"
 
+
 ##### Jinja formatting for response queries #####
 j2send = """{
+
+
 "comment": "##     Your IP Address is {{ ip }} ({{ port }})     ##",
+
+
 "family": "{{ family }}",
 "ip": "{{ ip }}",
 "port": "{{ port }}",
@@ -54,95 +43,111 @@ j2send = """{
 "sponsor": "Served by BSD Cafe, https://bsd.cafe/"
 }""" % version
 
-##### DNS Server Functionality #####
-class DNSResponder:
-    def __init__(self, address='::', port=5553):
-        self.address = address
-        self.port = port
-        self.sock = socket.socket(socket.AF_INET6, socket.SOCK_DGRAM)
-        self.sock.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 0)  # Enables dual-stack mode
-        self.sock.bind((self.address, self.port))
 
-    def run(self):
+##### Handles all prnting to console and logging to the logfile #####
-        logging.info("DNS Server listening on port %s for both IPv4 and IPv6", self.port)
+class log_management:
+	def __init__(self):
+		self.logpath = "/var/log/checkmyip/"  # Log file directory path
+		self.logfile = "/var/log/checkmyip/%scheckmyip.log" % \
+			time.strftime("%Y-%m-%d_")  # Log file full path
+		self.paramikolog = "/var/log/checkmyip/%sssh.log" % \
+			time.strftime("%Y-%m-%d_")  # SSH log file path
+		self.thread = threading.Thread(target=self._change_logfiles)
+		self.thread.daemon = True
+		self.thread.start()  # Start talker thread to listen to port
+		self._publish_methods()  # Publish the console and log methods to glob
+		self.can_log = True  # Variable used to check if we can log
+		try:  # Try to configure the SSH log file, create dir if fail
+			paramiko.util.log_to_file(self.paramikolog)
+		except IOError:
+			self._create_log_dir()
+	def _logger(self, data):  # Logging method published to global as 'log'
+		logdata = time.strftime("%Y-%m-%d %H:%M:%S") + ":   " + data + "\n"
+		if self.can_log:
+			try:  # Try to write to log, create log dir if fail
+				f = open(self.logfile, 'a')
+				f.write(logdata)
+				f.close()
+			except IOError:
+				self._console("Unable to log to logfile %s. Creating log directory" % self.logfile)
+				self.can_log = False
+				self._create_log_dir()
+		self._console(logdata)
+	def _console(self, data, timestamp=False):
+		if timestamp:
+			logdata = time.strftime("%Y-%m-%d %H:%M:%S") + ":   " + data + "\n"
+		else:
+			logdata = data
+		print(logdata)
+	def _publish_methods(self):
+		global log
+		global console
+		log = self._logger  # Global method used to write to the log file
+		console = self._console  # Global method used to write to the console
+	def _create_log_dir(self):  # Create the directory for logging
+		os.system('mkdir -p ' + self.logpath)
+		self._console("Logpath (%s) created" % self.logpath)
+		self.can_log = True
+	def _change_logfiles(self, thread=True):
 		while True:
-            try:
+			time.sleep(10)
-                data, addr = self.sock.recvfrom(1024)
+			self.logfile = "/var/log/checkmyip/%scheckmyip.log" % \
-                threading.Thread(target=self.handle_query, args=(data, addr), daemon=True).start()
+				time.strftime("%Y-%m-%d_")  # Log file full path
-            except Exception as e:
+			self.paramikolog = "/var/log/checkmyip/%sssh.log" % \
-                logging.error("DNS Server error: %s", e)
+				time.strftime("%Y-%m-%d_")  # SSH log file path
+			paramiko.util.log_to_file(self.paramikolog)
 
-    def handle_query(self, data, addr):
-        try:
-            request = DNSRecord.parse(data)
-            qname = request.q.qname
-            qtype = request.q.qtype
-            ip, port, *_ = addr  # Get IP and port; ignore other details
 
-            # Normalize IPv6 address (remove IPv4 mapping if exists)
+##### Creates a RSA key for use by paramiko #####
-            if ip.startswith("::ffff:"):
+class rsa_key:
-                ip = ip[7:]
-
-            # Only respond to TXT queries for myip.bsd.cafe
-            if qname.matchGlob('myip.bsd.cafe') and qtype == QTYPE.TXT:
-                response = DNSRecord(DNSHeader(id=request.header.id, qr=1, aa=1, ra=1), q=request.q)
-                response.add_answer(RR(qname, QTYPE.TXT, ttl=60, rdata=TXT(ip)))
-                self.sock.sendto(response.pack(), addr)
-        except Exception as e:
-            logging.error("Error handling DNS query: %s", e)
-
-##### Creates an RSA key for use by paramiko #####
-class RSAKey:
 	data = """-----BEGIN RSA PRIVATE KEY-----
-MIICWgIBAAKBgQDTj1bqB4WmayWNPB+8jVSYpZYk80Ujvj680pOTh2bORBjbIAyz
+	MIICWgIBAAKBgQDTj1bqB4WmayWNPB+8jVSYpZYk80Ujvj680pOTh2bORBjbIAyz
-oWGW+GUjzKxTiiPvVmxFgx5wdsFvF03v34lEVVhMpouqPAYQ15N37K/ir5XY+9m/
+	oWGW+GUjzKxTiiPvVmxFgx5wdsFvF03v34lEVVhMpouqPAYQ15N37K/ir5XY+9m/
-d8ufMCkjeXsQkKqFbAlQcnWMCRnOoPHS3I4vi6hmnDDeeYTSRvfLbW0fhwIBIwKB
+	d8ufMCkjeXsQkKqFbAlQcnWMCRnOoPHS3I4vi6hmnDDeeYTSRvfLbW0fhwIBIwKB
-gBIiOqZYaoqbeD9OS9z2K9KR2atlTxGxOJPXiP4ESqP3NVScWNwyZ3NXHpyrJLa0
+	gBIiOqZYaoqbeD9OS9z2K9KR2atlTxGxOJPXiP4ESqP3NVScWNwyZ3NXHpyrJLa0
-EbVtzsQhLn6rF+TzXnOlcipFvjsem3iYzCpuChfGQ6SovTcOjHV9z+hnpXvQ/fon
+	EbVtzsQhLn6rF+TzXnOlcipFvjsem3iYzCpuChfGQ6SovTcOjHV9z+hnpXvQ/fon
-soVRZY65wKnF7IAoUwTmJS9opqgrN6kRgCd3DASAMd1bAkEA96SBVWFt/fJBNJ9H
+	soVRZY65wKnF7IAoUwTmJS9opqgrN6kRgCd3DASAMd1bAkEA96SBVWFt/fJBNJ9H
-tYnBKZGw0VeHOYmVYbvMSstssn8un+pQpUm9vlG/bp7Oxd/m+b9KWEh2xPfv6zqU
+	tYnBKZGw0VeHOYmVYbvMSstssn8un+pQpUm9vlG/bp7Oxd/m+b9KWEh2xPfv6zqU
-avNwHwJBANqzGZa/EpzF4J8pGti7oIAPUIDGMtfIcmqNXVMckrmzQ2vTfqtkEZsA
+	avNwHwJBANqzGZa/EpzF4J8pGti7oIAPUIDGMtfIcmqNXVMckrmzQ2vTfqtkEZsA
-4rE1IERRyiJQx6EJsz21wJmGV9WJQ5kCQQDwkS0uXqVdFzgHO6S++tjmjYcxwr3g
+	4rE1IERRyiJQx6EJsz21wJmGV9WJQ5kCQQDwkS0uXqVdFzgHO6S++tjmjYcxwr3g
-H0CoFYSgbddOT6miqRskOQF3DZVkJT3kyuBgU2zKygz52ukQZMqxCb1fAkASvuTv
+	H0CoFYSgbddOT6miqRskOQF3DZVkJT3kyuBgU2zKygz52ukQZMqxCb1fAkASvuTv
-qfpH87Qq5kQhNKdbbwbmd2NxlNabazPijWuphGTdW0VfJdWfklyS2Kr+iqrs/5wV
+	qfpH87Qq5kQhNKdbbwbmd2NxlNabazPijWuphGTdW0VfJdWfklyS2Kr+iqrs/5wV
-HhathJt636Eg7oIjAkA8ht3MQ+XSl9yIJIS8gVpbPxSw5OMfw0PjVE7tBdQruiSc
+	HhathJt636Eg7oIjAkA8ht3MQ+XSl9yIJIS8gVpbPxSw5OMfw0PjVE7tBdQruiSc
-nvuQES5C9BMHjF39LZiGH1iLQy7FgdHyoP+eodI7
+	nvuQES5C9BMHjF39LZiGH1iLQy7FgdHyoP+eodI7
------END RSA PRIVATE KEY-----
+	-----END RSA PRIVATE KEY-----
-"""
+	"""
-    def readlines(self):  # For use by paramiko.RSAKey.from_private_key
+	def readlines(self):  # For use by paramiko.RSAKey.from_private_key mthd
 		return self.data.split("\n")
-
+	def __call__(self):  # Recursive method uses own object as arg when called
-    def get_key(self):
 		return paramiko.RSAKey.from_private_key(self)
 
+
 ##### Imports and modifies the ServerInterface module for use by paramiko #####
-class SSHServer(paramiko.ServerInterface):
+class ssh_server (paramiko.ServerInterface):
 	def __init__(self):
 		self.event = threading.Event()
-
 	def check_channel_request(self, kind, chanid):
 		if kind == 'session':
 			return paramiko.OPEN_SUCCEEDED
 		return paramiko.OPEN_FAILED_ADMINISTRATIVELY_PROHIBITED
-
+	def check_auth_none(self, username):  # Auth none method left wide open
-    def check_auth_none(self, username):
 		return paramiko.AUTH_SUCCESSFUL
-
+	def get_allowed_auths(self, username):  # Give no auth options
-    def get_allowed_auths(self, username):
 		return 'none'
-
 	def check_channel_shell_request(self, channel):
 		self.event.set()
 		return True
-
+	def check_channel_pty_request(self, channel, term, width, height,
-    def check_channel_pty_request(self, channel, term, width, height, pixelwidth, pixelheight, modes):
+								   pixelwidth, pixelheight, modes):
 		return True
 
+
 ##### Method to merge Jinja templates #####
 def j2format(j2tmp, valdict):
 	template = jinja2.Template(j2tmp)
 	return template.render(valdict).replace("\n", "\r\n")
 
+
 ##### Cleans IP addresses coming from socket library #####
 def cleanip(addr):
 	ip, port = addr[:2]
@@ -154,84 +159,68 @@ def cleanip(addr):
 		family = "ipv4"
 	return ip, port, family  # Return cleaned IP and family
 
-##### TCP listener methods using ThreadPoolExecutor for better thread management #####
+
-def listener(port, talker, executor):
+##### TCP listener methods. Gets used once for each listening port #####
+def listener(port, talker):
 	listen_ip = ''
 	listen_port = port
 	buffer_size = 1024
 	while True:
-        try:
 		# Use AF_INET6 but also handle IPv4 connections
 		sock = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)
 		sock.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 0)  # Allow IPv4-mapped IPv6 addresses
 		sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
 		sock.bind((listen_ip, listen_port))
 		sock.listen(buffer_size)
-            logging.info("Listening on port %s", listen_port)
 		while True:
 			client, addr = sock.accept()
 			ip, port, family = cleanip(addr)  # Get cleaned IP info including family
 			valdict = {"ip": ip, "port": port, "family": family, "proto": ""}
-                executor.submit(talker, client, valdict)  # Submit to thread pool
+			thread = threading.Thread(target=talker, args=(client, valdict))
-        except Exception as e:
+			thread.start()  # Start talker thread to listen to port
-            logging.error("Listener on port %s encountered an error: %s", port, e)
-            time.sleep(5)  # Wait before retrying
 
 ##### Telnet responder method. Is run in own thread for each telnet query #####
 def telnet_talker(client, valdict, proto="telnet"):
-    try:
 	valdict.update({"proto": proto})  # Add the protocol to the value dict
-        logging.info(j2format(j2log, valdict))  # Log the query
+	log(j2format(j2log, valdict))  # Log the query to the console and logfile
 	# Send the query response
-        response = j2format(j2send, valdict) + "\n"
+	client.send(f'{j2format(j2send, valdict)}\n'.encode())
-        client.sendall(response.encode())
+	client.close()  # Close the channel
-    except Exception as e:
+
-        logging.error("Telnet talker error: %s", e)
-    finally:
-        client.close()  # Ensure the socket is closed
 
 ##### SSH responder method. Gets run in own thread for each SSH query #####
 def ssh_talker(client, valdict, proto="ssh"):
-    try:
+	def makefile():  # A hack to make Cisco SSH sessions work properly
-        def makefile(chan):
-            # A hack to make SSH sessions work properly
 		chan.makefile('rU').readline().strip('\r\n')
-
 	valdict.update({"proto": proto})
-        logging.info(j2format(j2log, valdict))
+	log(j2format(j2log, valdict))
-        t = paramiko.Transport(client)
+	t = paramiko.Transport(client, gss_kex=True)
 	t.set_gss_host(socket.getfqdn(""))
 	t.load_server_moduli()
-        t.add_server_key(RSAKey().get_key())  # RSA key object
+	t.add_server_key(rsa_key()())  # RSA key object nested call
-        server = SSHServer()
+	server = ssh_server()
 	t.start_server(server=server)
-
 	chan = t.accept(20)
 	if chan:
-            if not server.event.wait(10):
+		server.event.wait(10)
-                logging.warning("No shell request received.")
+		chan.send('%s\n' % j2format(j2send, valdict))  # Send the response
-                chan.close()
+		thread = threading.Thread(target=makefile)
-            else:
+		thread.start()  # Start hack in thread since it hangs indefinately
-                response = j2format(j2send, valdict) + "\n"
+		time.sleep(1)  # Wait a second
-                chan.send(response)
+		chan.close()  # And kill the SSH channel
-                threading.Thread(target=makefile, args=(chan,), daemon=True).start()
+	client.close()  # And kill the session
-                time.sleep(1)
+
-                chan.close()
-    except Exception as e:
-        logging.error("SSH talker error: %s", e)
-    finally:
-        client.close()
 
+##### HTTP responder method. Gets run in own thread for each HTTP query #####
+##### Automatically detects if client is a browser or a telnet client   #####
 ##### HTTP responder method. Gets run in own thread for each HTTP query #####
 def http_talker(client, valdict, proto="http"):
-    try:
+    time.sleep(.1)  # Sleep to allow the client to send some data
-        time.sleep(0.1)  # Allow client to send data
+    client.setblocking(0)  # Set the socket recv as non-blocking
-        client.settimeout(5.0)  # Set timeout to prevent blocking indefinitely
     browser = False  # Is the client using a browser?
     headers = {}
     try:
         data = client.recv(2048)  # Receive data from the buffer (if any)
-            if data:
         request_lines = data.decode().split('\r\n')
         for line in request_lines:
             if ": " in line:
@@ -243,106 +232,87 @@ def http_talker(client, valdict, proto="http"):
             ip, port, family = cleanip((real_ip, valdict['port']))
             valdict.update({"ip": ip, "family": family})
         browser = True  # Set client browser to True
-        except socket.timeout:
+    except socket.error:  # If buffer was empty, then like a telnet client on TCP80
         browser = False  # Set client browser to False
-        except Exception as e:
-            logging.error("HTTP talker recv error: %s", e)
-            browser = False
-
     if not browser:  # If the client is not a browser
         telnet_talker(client, valdict, "http-telnet")  # Hand to telnet_talker
     else:  # If client is a browser
+        # Proceed with standard HTTP response (with headers)
         valdict.update({"proto": proto})
-            logging.info(j2format(j2log, valdict))
+        log(j2format(j2log, valdict))
-            response_body_raw = j2format(j2send, valdict) + "\n"
+        response_body_raw = j2format(j2send, valdict)+"\n"
-            if request_lines and "/raw" in request_lines[0]:
+        if request_lines[0].split()[1] == "/raw":
-                try:
             json_content = json.loads(response_body_raw)
-                    response_body_raw = json_content.get('ip', '')
+            response_body_raw = json_content['ip']
-                except json.JSONDecodeError:
+        response_headers_raw = """HTTP/1.1 200 OK
-                    response_body_raw = "Invalid JSON response."
+Content-Length: %s
-            response_headers_raw = (
+Content-Type: application/json; encoding=utf8
-                "HTTP/1.1 200 OK\r\n"
+Connection: close""" % str(len(response_body_raw))  # Response with headers
-                f"Content-Length: {len(response_body_raw)}\r\n"
+        client.send(f'{response_headers_raw}\n\n{response_body_raw}'.encode())
-                "Content-Type: application/json; charset=utf-8\r\n"
+        client.close()
-                "Connection: close\r\n\r\n"
+
-            )
+
-            client.sendall(response_headers_raw.encode() + response_body_raw.encode())
-    except Exception as e:
-        logging.error("HTTP talker error: %s", e)
-    finally:
-        client.close()  # Ensure the socket is closed
 
 ##### Server startup method. Starts a listener thread for each TCP port #####
 def start():
-    talkers = {
+	talkers = {2222: ssh_talker, 2223: telnet_talker,
-        2222: ssh_talker,
+	2280: http_talker}  # Three listeners on different ports
-        2223: telnet_talker,
+	for talker in talkers:
-        2280: http_talker
-    }  # Three listeners on different ports
-    max_workers = 100  # Define maximum number of threads
-    with ThreadPoolExecutor(max_workers=max_workers) as executor:
-        for port, talker in talkers.items():
 		# Launch a thread for each listener
-            threading.Thread(target=listener, args=(port, talker, executor), daemon=True).start()
+		thread = threading.Thread(target=listener,
-        # Start DNS server in a new thread
+			args=(talker, talkers[talker]))
-        dns_server = DNSResponder(port=5553)  # Assuming DNS is on port 5553 as per original code
+		thread.daemon = True
-        threading.Thread(target=dns_server.run, daemon=True).start()
+		thread.start()
-        logging.info("All services started.")
+	while True:  # While loop to allow a CTRL-C interrupt when interactive
-        while True:  # Keep the main thread alive
 		try:
 			time.sleep(1)
 		except KeyboardInterrupt:
-                logging.info("Shutting down server.")
+			quit()
-                sys.exit(0)
+
 
 ##### Client class to be used to make API calls to CheckMyIP server #####
 class CheckMyIP_Client:
 	def __init__(self):
-        self._json = json  # Direct reference to json module
+		self._json = __import__('json')  # Import the JSON library
-        self._socket = socket  # Direct reference to socket module
+		self._socket = __import__('socket')  # Import the socket library
 		self._raw_data = None  # Initialize the _raw_data variable
 		self._data = None  # Initialize the _data variable
 		self._af = "auto"  # Set the IP address family type to "auto"
 		self.server = "telnetmyip.com"  # Set the default CheckMyIP server
-
 	def get(self):  # Primary method to run IP check
-        sock = None
-        try:
 		if self._af == "auto":  # If we are using an auto address family
 			try:  # Try using IPv6
-                    sock = self._socket.socket(self._socket.AF_INET6, self._socket.SOCK_STREAM)
+				sock = self._socket.socket(self._socket.AF_INET6,
+				self._socket.SOCK_STREAM)
 				sock.connect((self.server, 23))
 			except:  # Fall back to IPv4 if IPv6 fails
-                    sock = self._socket.socket(self._socket.AF_INET, self._socket.SOCK_STREAM)
+				sock = self._socket.socket(self._socket.AF_INET,
+				self._socket.SOCK_STREAM)
 				sock.connect((self.server, 23))
 		elif self._af == "ipv6":  # If we are using the IPv6 address family
-                sock = self._socket.socket(self._socket.AF_INET6, self._socket.SOCK_STREAM)
+			sock = self._socket.socket(self._socket.AF_INET6,
+			self._socket.SOCK_STREAM)
 			sock.connect((self.server, 23))
 		elif self._af == "ipv4":  # If we are using the IPv4 address family
-                sock = self._socket.socket(self._socket.AF_INET, self._socket.SOCK_STREAM)
+			sock = self._socket.socket(self._socket.AF_INET,
+			self._socket.SOCK_STREAM)
 			sock.connect((self.server, 23))
 		self._raw_data = sock.recv(1024).decode()
-            self._data = self._json.loads(self._raw_data)  # Receive data from the buffer
+		self._data = self._json.loads(self._raw_data)  # Recieve data from the buffer
+		sock.close()  # Close the socket
 		return self._data  # Return the JSON data
-        except Exception as e:
-            logging.error("CheckMyIP_Client error: %s", e)
-            return None
-        finally:
-            if sock:
-                sock.close()  # Ensure the socket is closed
-
 	def set_family(self, family):  # Method to set the IP address family
 		allowed = ["auto", "ipv4", "ipv6"]  # Allowed input values
 		if family in allowed:
 			self._af = family
 		else:
-            raise ValueError("Allowed families are 'auto', 'ipv4', 'ipv6'")
+			raise Exception("Allowed families are 'auto', 'ipv4', 'ipv6'")
 
 ### CheckMyIP_Client Example Usage ###
-# client = CheckMyIP_Client()
+#client = CheckMyIP_Client()
-# data = client.get()
+#client.get()
-# print(data)
+
 
 if __name__ == "__main__":
+	logging = log_management()  # Instantiate log class
 	start()  # Start the server