From 245fe9957ab7e0feae5ce0185659a34f37a7c1a8 Mon Sep 17 00:00:00 2001 From: 0x1eef <0x1eef@protonmail.com> Date: Sat, 17 Aug 2024 18:56:38 -0300 Subject: [PATCH] Fix shellcheck errors --- libexec/sourcezap/commands/sourcezap-teardown | 6 +++--- libexec/sourcezap/setup/setup-doas | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libexec/sourcezap/commands/sourcezap-teardown b/libexec/sourcezap/commands/sourcezap-teardown index 1f8fb65..db7c1da 100755 --- a/libexec/sourcezap/commands/sourcezap-teardown +++ b/libexec/sourcezap/commands/sourcezap-teardown @@ -15,9 +15,9 @@ user=_sourcezap ## # main if [ "$(id -u)" = "0" ]; then - pw userdel -n "${user}" || true - pw groupdel -n "${user}" || true - rm -rf /home/"${user}"/ || true + pw userdel -n "${user}" || true + pw groupdel -n "${user}" || true + rm -rf /home/"${user:?}"/ || true printok "done" else printerr "you must be root" diff --git a/libexec/sourcezap/setup/setup-doas b/libexec/sourcezap/setup/setup-doas index 40bb3ae..87c2994 100755 --- a/libexec/sourcezap/setup/setup-doas +++ b/libexec/sourcezap/setup/setup-doas @@ -16,8 +16,7 @@ sharedir="${localbase}"/share/sourcezap # main src="${sharedir}"/doas.conf dest="${localbase}"/etc/doas.conf -cat "${src}" | -while read -r line; do +while read -r line < "${src}"; do if grep -q "${line}" "${dest}"; then continue fi